Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marciflip gtest #4431

Merged
merged 4 commits into from
May 12, 2021
Merged

Marciflip gtest #4431

merged 4 commits into from
May 12, 2021

Conversation

tgiroux
Copy link
Contributor

@tgiroux tgiroux commented Apr 29, 2021

Description

GTest for marciflip. I think having a single test case is appropriate here.
Couldn't reuse cubes from marcical tests due to their shape and summing mode.
Also moved marcical test cubes to their own directory.

Related Issue

Motivation and Context

Test translations.

How Has This Been Tested?

New test passing on osx.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change (update to the documentation; no code change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read and agree to abide by the Code of Conduct
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have added myself to the .zenodo.json document.
  • I have added any user impacting changes to the CHANGELOG.md document.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

@tgiroux tgiroux requested a review from jessemapel April 29, 2021 19:41
Copy link
Contributor

@jessemapel jessemapel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, with one change. We should probably have two tests, with and without summing, but the original didn't so it's okay for the conversion not to.

isis/tests/FunctionalTestsMarciflip.cpp Outdated Show resolved Hide resolved
@tgiroux tgiroux requested a review from jessemapel May 12, 2021 17:08
Copy link
Contributor

@jessemapel jessemapel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@jessemapel
Copy link
Contributor

This can be merged once CI tests pass

@jessemapel jessemapel merged commit 8a6c8fd into DOI-USGS:dev May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants