Normalized test names and file names #4366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scsides
suggested changes
Mar 16, 2021
isis/tests/FunctionalTestsCamdev.cpp
Outdated
| @@ -13,7 +13,7 @@ using namespace Isis; | |||
|
|
|||
| static QString APP_XML = FileName("$ISISROOT/bin/xml/camdev.xml").expanded(); | |||
|
|
|||
| TEST_F(LineScannerCube, FunctionalTestsCamDevDefault) { | |||
| TEST_F(LineScannerCube, FunctionalTestCamDevDefault) { | |||
There was a problem hiding this comment.
If I'm following the normalization, shouldn't this be "FunctionalTestCamdevDefault" ?
isis/tests/FunctionalTestsMoccal.cpp
Outdated
| @@ -12,10 +12,10 @@ using namespace Isis; | |||
|
|
|||
| static QString APP_XML = FileName("$ISISROOT/bin/xml/moccal.xml").expanded(); | |||
|
|
|||
| TEST_F(MgsMocCube, FunctionalTestMroMoccalDefault) { | |||
| TEST_F(MgsMocCube, FunctionalTestMromoccalDefault) { | |||
There was a problem hiding this comment.
Not sure how this got through the first time. "moccal" is an MGS app not an MRO. On the other hand, the app name is "moccal" not "mgsmoccal", shouldn't this just be "FunctionalTestMoccalDefault" ?
isis/tests/FunctionalTestsMoccal.cpp
Outdated
| EXPECT_DOUBLE_EQ(oCubeStats->Average(), 0.056909484090283513); | ||
| EXPECT_DOUBLE_EQ(oCubeStats->Sum(), 22.763793636113405); | ||
| EXPECT_DOUBLE_EQ(oCubeStats->ValidPixels(), 400); | ||
| EXPECT_DOUBLE_EQ(oCubeStats->StandardDeviation(), 0.0021719888294085255); | ||
| } | ||
|
|
||
|
|
||
| TEST_F(MgsMocCube, FunctionalTestMroMoccalIofFalse) { | ||
| TEST_F(MgsMocCube, FunctionalTestMromoccalIofFalse) { |
isis/tests/FunctionalTestsMoccal.cpp
Outdated
| @@ -85,10 +85,10 @@ TEST_F(MgsMocCube, FunctionalTestMroMoccalIofFalse) { | |||
| } | |||
|
|
|||
|
|
|||
| TEST_F(MgsMocCube, FunctionalTestMroMoccalNullwagoTrue) { | |||
| TEST_F(MgsMocCube, FunctionalTestMromoccalNullwagoTrue) { | |||
isis/tests/FunctionalTestsMoccal.cpp
Outdated
| @@ -121,7 +121,7 @@ TEST_F(MgsMocCube, FunctionalTestMroMoccalNullwagoTrue) { | |||
| } | |||
|
|
|||
|
|
|||
| TEST_F(MgsMocCube, FunctionalTestMroMoccalCameraComparison) { | |||
| TEST_F(MgsMocCube, FunctionalTestMromoccalCameraComparison) { | |||
Kelvinrr
reviewed
Mar 16, 2021
|
@scsides Does this look good to go? |
scsides
approved these changes
Mar 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the file and test names to better match the guidelines described here
Description
Related Issue
#4206
Motivation and Context
Test names should be consistent
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words: