-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
History object tests #4314
Merged
Merged
History object tests #4314
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
#include "Fixtures.h" | ||
#include "History.h" | ||
|
||
#include "gmock/gmock.h" | ||
|
||
using namespace Isis; | ||
|
||
TEST(HistoryTests, HistoryTestsDefaultConstructor) { | ||
History history; | ||
|
||
Pvl historyPvl = history.ReturnHist(); | ||
EXPECT_EQ(historyPvl.groups(), 0); | ||
} | ||
|
||
TEST_F(HistoryBlob, HistoryTestsFromBlob) { | ||
History readHistory(historyBlob); | ||
|
||
Pvl historyPvl = readHistory.ReturnHist(); | ||
ASSERT_TRUE(historyPvl.hasObject("mroctx2isis")); | ||
EXPECT_TRUE(historyPvl.findObject("mroctx2isis").hasGroup("UserParameters")); | ||
} | ||
|
||
TEST_F(HistoryBlob, HistoryTestsAddEntry) { | ||
History history; | ||
|
||
history.AddEntry(historyPvl); | ||
|
||
Pvl newHistoryPvl = history.ReturnHist(); | ||
ASSERT_TRUE(newHistoryPvl.hasObject("mroctx2isis")); | ||
EXPECT_TRUE(newHistoryPvl.findObject("mroctx2isis").hasGroup("UserParameters")); | ||
} | ||
|
||
TEST_F(HistoryBlob, HistoryTeststoBlob) { | ||
History history(historyBlob); | ||
|
||
Blob *blob = history.toBlob(); | ||
|
||
std::stringstream os; | ||
char *blob_buffer = blob->getBuffer(); | ||
Pvl newHistoryPvl; | ||
for (int i = 0; i < blob->Size(); i++) { | ||
os << blob_buffer[i]; | ||
} | ||
os >> newHistoryPvl; | ||
|
||
ASSERT_TRUE(newHistoryPvl.hasObject("mroctx2isis")); | ||
EXPECT_TRUE(newHistoryPvl.findObject("mroctx2isis").hasGroup("UserParameters")); | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't interrogate the Blob itself, I would just test History -> Blob -> History works correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe? That's testing a lot in one test, which is why I thought chunking the test up would be better.
It seems like we either test all of the functionality of the class in one test that is an end to end test, or we chunk it up like I have. In the end to end test you would use the default constructor, the AddEntry method, the toBlob method, the blob constructor and the ReturnHist method to examine the expect PVL