Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated ISIS3 references to ISIS #4292

Merged
merged 6 commits into from
Feb 19, 2021
Merged

Conversation

amystamile-usgs
Copy link
Contributor

Remove references to ISIS3 and replace with references to ISIS

Description

Updated any references of ISIS3 to ISIS. I left any mention of ISIS3 in history comments and anything pertaining specifically to ISIS3 version.

Related Issue

Motivation and Context

ISIS 3/4 Transition Cleanup FY21

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change (update to the documentation; no code change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read and agree to abide by the Code of Conduct
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have added myself to the .zenodo.json document.
  • I have added any user impacting changes to the CHANGELOG.md document.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

Copy link
Contributor

@scsides scsides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch on the "ISIS 3"s.

Do you want to handle the "Isis" and "isis" occurrences in this PR or would it be easier as a new PR?

@amystamile-usgs
Copy link
Contributor Author

Good catch on the "ISIS 3"s.

Do you want to handle the "Isis" and "isis" occurrences in this PR or would it be easier as a new PR?

I can do another sweep for Isis and isis and add it to this PR.

@amystamile-usgs
Copy link
Contributor Author

@scsides I checked through again and did not find any additional Isis3 or isis3 references other than in file paths or in history comments. Are you referring to updating "Isis" and "isis" to "ISIS"?

@amystamile-usgs
Copy link
Contributor Author

Updated "isis" and "Isis" to "ISIS". Ignored any disclaimers with "Isis" since these will be updated in another PR.

kaitlyndlee
kaitlyndlee previously approved these changes Feb 17, 2021
scsides
scsides previously approved these changes Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants