lorri2isis Test Conversion

[amystamile-usgs]

Test Conversion for lorri2isis app

Description

Converted lorri2isis/main.cpp to lorri2isis/lorri2isis.cpp and lorri2isis.h. Added 7 gtests.

Related Issue

Test coversions.

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Documentation change (update to the documentation; no code change)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• I have read and agree to abide by the Code of Conduct
• I have read the CONTRIBUTING document.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.
• I have added myself to the .zenodo.json document.
• I have added any user impacting changes to the CHANGELOG.md document.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

• I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

[acpaquette]

Overall looks solid! Just one quick question about a test conversion

[acpaquette]

Any particular reason that this didn't get converted? I would assume because the summing modes don't effect the import app and the main logic for getting the summing mode is in the translation.

[amystamile-usgs]

@acpaquette I was not sure how this test was different than the tests I already implemented. If you think it'll be useful to add it in, let me know.

[acpaquette]

I think this was testing a translation file specific look up. If you checkout this translation file the it looks for a particular key for the summing mode.

If the app was doing anything with the summing mode I would suggest reimplementing the test as a gtest. As you said this test isn't doing anything directly with the app so I think we can keep it as is. Good job on this PR!

[acpaquette]

👍