Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed GMM++ dependency #4265

Merged
merged 2 commits into from
Feb 23, 2021
Merged

Removed GMM++ dependency #4265

merged 2 commits into from
Feb 23, 2021

Conversation

jessemapel
Copy link
Contributor

Description

GMM++ is a snowflake dependency of ours that was replaced with Armadillo a while ago. It seems we never got around to removing it from the environment?

Related Issue

#2684

Motivation and Context

This helps get us in sync with conda-forge and reduces the number of dependencies that we have to serve.

How Has This Been Tested?

Built on OSX and Ubuntu. Tests passed on Ubuntu.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change (update to the documentation; no code change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read and agree to abide by the Code of Conduct
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have added myself to the .zenodo.json document.
  • I have added any user impacting changes to the CHANGELOG.md document.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

@jessemapel
Copy link
Contributor Author

I think this is ready to go based on CI. I tagged the continuous support folks to talk a quick look.

Copy link
Contributor

@AustinSanders AustinSanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, but it looks like cmake is failing on centos.

If that's expected / unrelated, then this is good to go.

@jessemapel
Copy link
Contributor Author

Dev build is failing in the same way https://astroservices.usgs.gov/jenkins/job/USGS-Astrogeology/job/ISIS3/job/dev/lastBuild/flowGraphTable/

I think I need to check the ALE that I uploaded for GCC 4 :(

Copy link
Collaborator

@acpaquette acpaquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing that if ISIS is building on Ubuntu, Fedora, and Mac this change will likely not hurt CentOS builds. 👍

@jessemapel jessemapel merged commit fe149f5 into DOI-USGS:dev Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants