Test Fixes #3898
Merged
Test Fixes #3898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kelvinrr
commented
Jun 5, 2020
| @@ -34,7 +34,7 @@ for (lbl in labels) { | |||
| condaEnv("isis3") { | |||
| // Environment | |||
| loginShell """ | |||
| conda install -c conda-forge python=3 | |||
| conda install -c conda-forge python=3 findutils | |||
There was a problem hiding this comment.
temporary fix, PR into the docker repo incoming. Not sure how that process will go to get the new containers running (had flakiness from updating image:latest and not being pulled as k8s doesn't see it as a newer version of the container ) so I don't want to count on it too much at the moment.
acpaquette
reviewed
Jun 5, 2020
| @@ -46,7 +46,7 @@ Embree shape model status: | |||
| Model has intersection? true | |||
| Surface Point: ( 0.2908 , -0.0019 , 0.0005 ) | |||
| Model has normal? true | |||
| Surface Normal: ( 0.847198 , -0.194495 , 0.494395 ) | |||
| Surface Normal: ( 0.8471 , -0.1944 , 0.4943 ) | |||
There was a problem hiding this comment.
Is this rounding a Mac vs Linux issue?
There was a problem hiding this comment.
Sort of, Embree only does floating point precision calculations and we sometimes see very small differences based on OS.
jessemapel
approved these changes
Jun 5, 2020
krlberry
approved these changes
Jun 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This should get the currently failing tests on Linux boxes passing again.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words: