Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MacOS tests #3887

Merged
merged 22 commits into from
Jun 3, 2020
Merged

MacOS tests #3887

merged 22 commits into from
Jun 3, 2020

Conversation

Kelvinrr
Copy link
Collaborator

@Kelvinrr Kelvinrr commented Jun 1, 2020

Mostly from #3720

This appends to the PR some changes needed to get ISIS passing for MacOS 10.15

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change (update to the documentation; no code change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read and agree to abide by the Code of Conduct
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

@Kelvinrr Kelvinrr marked this pull request as ready for review June 2, 2020 15:18
@Kelvinrr
Copy link
Collaborator Author

Kelvinrr commented Jun 2, 2020

@jessemapel
Copy link
Contributor

Can we close #3720 in favor of this?

Copy link
Contributor

@jessemapel jessemapel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable. Once Jenkins is sorted, testing can be evaluated.

@kaitlyndlee
Copy link
Contributor

Looks good to me after Jesse's comment is responded to.

scsides
scsides previously approved these changes Jun 2, 2020
Copy link
Contributor

@scsides scsides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to parameterize the docker files? They look to be nearly identical

@Kelvinrr
Copy link
Collaborator Author

Kelvinrr commented Jun 2, 2020

@jessemapel We can close #3720 in favor of this one. Once tests finish on Jenkins I think this is good to merge. Some module tests failed that I need to check out. If they look fine local I'll merge it. Most app failures are NFS failures.

@Kelvinrr
Copy link
Collaborator Author

Kelvinrr commented Jun 3, 2020

Failing fedora unit test passed locally, so I'll assume it was a fluke and merge this.

@Kelvinrr Kelvinrr merged commit 9a9c350 into DOI-USGS:dev Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants