-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MacOS tests #3887
MacOS tests #3887
Conversation
Can we close #3720 in favor of this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable. Once Jenkins is sorted, testing can be evaluated.
Looks good to me after Jesse's comment is responded to. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to parameterize the docker files? They look to be nearly identical
@jessemapel We can close #3720 in favor of this one. |
Failing fedora unit test passed locally, so I'll assume it was a fluke and merge this. |
Mostly from #3720
This appends to the PR some changes needed to get ISIS passing for MacOS 10.15
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words: