Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matchups command not working for NHL leagues #22

Closed
DMcP89 opened this issue Aug 12, 2021 · 0 comments · Fixed by #44
Closed

Matchups command not working for NHL leagues #22

DMcP89 opened this issue Aug 12, 2021 · 0 comments · Fixed by #44
Labels
bug Something isn't working

Comments

@DMcP89
Copy link
Owner

DMcP89 commented Aug 12, 2021

The $matchups command is not returning anything when using an NHL league.

[2021-11-30 23:18:44,546 INFO] [/home/dave/workspace/python/bots/harambot/harambot/cogs/yahoo.py.yahoo.standings] standings called
Error while fetching matchups for league: 70652
Traceback (most recent call last):
  File "/home/dave/workspace/python/bots/harambot/harambot/yahoo_api.py", line 132, in get_matchups
    team1_win_probability = "{:.0%}".format(team1[1]['win_probability'])
KeyError: 'win_probability'

Seems like the win probability will be not always get returned.

@DMcP89 DMcP89 added the bug Something isn't working label Aug 12, 2021
@DMcP89 DMcP89 changed the title Player details command not working for NHL leagues Matchups command not working for NHL leagues Dec 1, 2021
DMcP89 pushed a commit that referenced this issue Dec 1, 2021
DMcP89 added a commit that referenced this issue Dec 1, 2021
@DMcP89 DMcP89 closed this as completed Dec 1, 2021
@DMcP89 DMcP89 linked a pull request Dec 2, 2021 that will close this issue
DMcP89 pushed a commit that referenced this issue Dec 21, 2021
DMcP89 added a commit that referenced this issue Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant