Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature puma patches [8/x] Batch processing of tree ref_coords [1/x] Interface #662

Merged
merged 29 commits into from
Sep 13, 2023

Conversation

sandro-elsweijer
Copy link
Collaborator

@sandro-elsweijer sandro-elsweijer commented Aug 1, 2023

Describe your changes here:
Add an interface for batch processing capabilities to the geometry evaluation of trees

Closes #409

All these boxes must be checked by the reviewers before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

  • The reviewer executed the new code features at least once and checked the results manually

  • The code follows the t8code coding guidelines

  • New source/header files are properly added to the Makefiles

  • The code is well documented

  • All function declarations, structs/classes and their members have a proper doxygen documentation

  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue)

Tests

  • The code is covered in an existing or new test case using Google Test

Github action

  • The code compiles without warning in debugging and release mode, with and without MPI (this should be executed automatically in a github action)

  • All tests pass (in various configurations, this should be executed automatically in a github action)

    If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

    • Should this use case be added to the github action?
    • If not, does the specific use case compile and all tests pass (check manually)

Scripts and Wiki

  • If a new directory with source-files is added, it must be covered by the script/find_all_source_files.scp to check the indentation of these files.
  • New Datatypes are added to t8indent_custom_datatypes.txt
  • If this PR introduces a new feature, it must be covered in an example/tutorial and a Wiki article.

Licence

  • The author added a BSD statement to doc/ (or already has one)

@sandro-elsweijer sandro-elsweijer self-assigned this Aug 1, 2023
@sandro-elsweijer sandro-elsweijer added enhancement Enhances already existing code New feature Adds a new feature to the code Follow-up PR and removed New feature Adds a new feature to the code labels Aug 1, 2023
@sandro-elsweijer sandro-elsweijer changed the base branch from main to feature-puma_patches_batch_processing August 2, 2023 12:20
@sandro-elsweijer sandro-elsweijer changed the title Feature puma patches [8/x] Batch processing of tree ref_coords Feature puma patches [8/x] Batch processing of tree ref_coords [1/x] Interface Aug 2, 2023
@jmark jmark self-assigned this Sep 4, 2023
Base automatically changed from feature-puma_patches_batch_processing to main September 11, 2023 08:46
@sandro-elsweijer sandro-elsweijer marked this pull request as ready for review September 11, 2023 08:47
@jmark
Copy link
Collaborator

jmark commented Sep 11, 2023

@sandro-elsweijer I took the liberty to update the public API of the squared disk geometry which I introduced some PRs ago. Your last merge with main broke the CI.

Copy link
Collaborator

@jmark jmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some updates of coords[3] were overlooked. Please fix this. Otherwise LGTM.

@jmark jmark merged commit 9387ee3 into main Sep 13, 2023
@jmark jmark deleted the feature-puma_patches_batch_processing_geometry branch September 13, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhances already existing code Follow-up PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: batch processing of points in the geometry classes
2 participants