Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallel polydata reader #634

Merged
merged 18 commits into from
Aug 8, 2023
Merged

Parallel polydata reader #634

merged 18 commits into from
Aug 8, 2023

Conversation

Davknapp
Copy link
Collaborator

@Davknapp Davknapp commented Jul 19, 2023

Implemented a parallel reader for vtkPolyData.
Restructured the parallel reader to decrease Code-duplication.

The merging of polyData and vtkUnstructuredGrids are slightly different, resulting in two slightly different merging-functions.

All these boxes must be checked by the reviewers before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

  • The reviewer executed the new code features at least once and checked the results manually

  • The code follows the t8code coding guidelines

  • New source/header files are properly added to the Makefiles

  • The code is well documented

  • All function declarations, structs/classes and their members have a proper doxygen documentation

  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue)

Tests

  • The code is covered in an existing or new test case using Google Test

Github action

  • The code compiles without warning in debugging and release mode, with and without MPI (this should be executed automatically in a github action)

  • All tests pass (in various configurations, this should be executed automatically in a github action)

    If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

    • Should this use case be added to the github action?
    • If not, does the specific use case compile and all tests pass (check manually)

Scripts and Wiki

  • If a new directory with source-files is added, it must be covered by the script/find_all_source_files.scp to check the indentation of these files.
  • New Datatypes are added to t8indent_custom_datatypes.txt
  • If this PR introduces a new feature, it must be covered in an example/tutorial and a Wiki article.

Licence

  • The author added a BSD statement to doc/ (or already has one)

@Davknapp Davknapp added enhancement Enhances already existing code tests labels Jul 19, 2023
@Davknapp Davknapp marked this pull request as draft July 20, 2023 07:35
@jmark jmark assigned jmark and unassigned jmark Jul 21, 2023
@jmark jmark added the draft Enhance the visibility that this is a draft. label Jul 21, 2023
Base automatically changed from cmesh_from_distributed_vtk to main July 25, 2023 14:37
@jmark
Copy link
Collaborator

jmark commented Jul 25, 2023

@Davknapp Please fix the merge conflicts and update the branch if applicable. Then I start the review.

@jmark jmark marked this pull request as ready for review July 25, 2023 15:39
@jmark jmark removed the draft Enhance the visibility that this is a draft. label Jul 25, 2023
@Davknapp Davknapp assigned jmark and unassigned Davknapp Jul 26, 2023
Copy link
Collaborator

@jmark jmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you also update t8_cmesh_read_from_vtk to be able to read paralle polydata files?

@jmark jmark assigned Davknapp and unassigned jmark Jul 27, 2023
Co-authored-by: Johannes Markert <[email protected]>
@Davknapp Davknapp assigned jmark and unassigned Davknapp Jul 28, 2023
jmark
jmark previously requested changes Jul 28, 2023
Copy link
Collaborator

@jmark jmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Just one final request.

Would you update t8_cmesh_read_from_vtk to be able to read paralle polydata files?

I had this comment in the last review, too. Maybe you overlooked it?

@jmark jmark assigned Davknapp and unassigned jmark Jul 28, 2023
@sandro-elsweijer sandro-elsweijer dismissed jmark’s stale review August 8, 2023 11:52

Was adressed, but jmark is on holiday and cannot dismiss this on his own

@sandro-elsweijer sandro-elsweijer merged commit 7e15608 into main Aug 8, 2023
@sandro-elsweijer sandro-elsweijer deleted the parallel_polydata_reader branch August 8, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhances already existing code tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants