Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vtk parallel reader #607

Merged
merged 11 commits into from
Jul 17, 2023
Merged

Vtk parallel reader #607

merged 11 commits into from
Jul 17, 2023

Conversation

Davknapp
Copy link
Collaborator

@Davknapp Davknapp commented Jul 4, 2023

I implemented two versions of a pvtu-reader.

The first version reads all files given by the pvtu file using a single main-proc. The current construction of the cmesh can be used in this case.
The second version reads several chunks (in vtk-language "pieces") of the files. If a proc reads multiple files the data is merged together. The construction of the cmesh is not enabled for this type of reader, but will be in the future on a seperate branch. Furthermore a proper test will be implemented.

All these boxes must be checked by the reviewers before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

  • The reviewer executed the new code features at least once and checked the results manually

  • The code follows the t8code coding guidelines

  • New source/header files are properly added to the Makefiles

  • The code is well documented

  • All function declarations, structs/classes and their members have a proper doxygen documentation

  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue)

Tests

  • The code is covered in an existing or new test case using Google Test

Github action

  • The code compiles without warning in debugging and release mode, with and without MPI (this should be executed automatically in a github action)

  • All tests pass (in various configurations, this should be executed automatically in a github action)

    If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

    • Should this use case be added to the github action?
    • If not, does the specific use case compile and all tests pass (check manually)

Scripts and Wiki

  • If a new directory with source-files is added, it must be covered by the script/find_all_source_files.scp to check the indentation of these files.
  • New Datatypes are added to t8indent_custom_datatypes.txt
  • If this PR introduces a new feature, it must be covered in an example/tutorial and a Wiki article.

Licence

  • The author added a BSD statement to doc/ (or already has one)

Davknapp added 5 commits July 3, 2023 14:10
a) a simple pvtu reader, reading everything on a single proc.
b) a distributed pvtu reader, reading chunks of the files on several procs.

TODO: Build the partition of the cmesh when using b).
@Davknapp Davknapp added enhancement Enhances already existing code New feature Adds a new feature to the code labels Jul 4, 2023
@jmark jmark self-assigned this Jul 12, 2023
@jmark jmark assigned Davknapp and unassigned jmark Jul 12, 2023
@Davknapp Davknapp assigned jmark and unassigned Davknapp Jul 13, 2023
@jmark jmark assigned Davknapp and unassigned jmark Jul 14, 2023
@Davknapp Davknapp assigned jmark and unassigned Davknapp Jul 14, 2023
@jmark jmark merged commit e0a710d into main Jul 17, 2023
@jmark jmark deleted the vtk-parallel_reader branch July 17, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhances already existing code New feature Adds a new feature to the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants