-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tutorial step7 - interpolation #560
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When executing the code in debug-mode I get memory-issues (Leftover references
). Please have a look at all your allocated resources and check if you free´d or unref´d them correctly.
If I understand the example correctly the element_own_data
holds the distance of the element_midpoint to the midpoint ot the sphere. Hence I should see a spherical increase of the element_data in paraview. But I can't observe it, see the attached picture of the initial uniform refined forest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All in all it looks good to me, but when executing I get a refcount error:
[t8] Constructed uniform forest with 4096 global elements.
[t8] Into t8_forest_adapt from 4096 total elements
[t8] Done t8_forest_adapt with 1408 total elements
[t8] Into t8_forest_iterate_replace
[t8] Done t8_forest_iterate_replace
[libsc 0] Abort: Assertion 'forest->rc.refcount > 0'
[libsc 0] Abort: ../t8code/src/t8_forest/t8_forest.c:1676
[libsc 0] Abort: Obtained 9 stack frames
[libsc 0] Stack 0: t8_step7_interpolation() [0x48c969]
[libsc 0] Stack 1: t8_step7_interpolation() [0x48c937]
[libsc 0] Stack 2: t8_step7_interpolation() [0x48cb6c]
[libsc 0] Stack 3: t8_step7_interpolation() [0x4131ed]
[libsc 0] Stack 4: t8_step7_interpolation() [0x405716]
[libsc 0] Stack 5: t8_step7_interpolation() [0x405786]
[libsc 0] Stack 6: t8_step7_interpolation() [0x405827]
[libsc 0] Stack 7: libc.so.6(__libc_start_main+0xf3) [0x7f60974cb083]
[libsc 0] Stack 8: t8_step7_interpolation() [0x404a3e]
Abort(1) on node 0 (rank 0 in comm 0): application called MPI_Abort(MPI_COMM_WORLD, 1) - process 0
Add tutorial step7 - interpolation
Tutorial step 7 for the interpolation process.
Wiki article: https://github.com/DLR-AMR/t8code/wiki/Step-7-Interpolation
Describe your changes here:
All these boxes must be checked by the reviewers before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
The reviewer executed the new code features at least once and checked the results manually
The code follows the t8code coding guidelines
New source/header files are properly added to the Makefiles
The code is well documented
All function declarations, structs/classes and their members have a proper doxygen documentation
All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue)
Tests
Github action
The code compiles without warning in debugging and release mode, with and without MPI (this should be executed automatically in a github action)
All tests pass (in various configurations, this should be executed automatically in a github action)
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
script/find_all_source_files.scp
to check the indentation of these files.Licence
doc/
(or already has one)