Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature puma patches [2/x] add element ref coords interface #515

Merged
merged 6 commits into from
Apr 24, 2023

Conversation

sandro-elsweijer
Copy link
Collaborator

@sandro-elsweijer sandro-elsweijer commented Apr 12, 2023

Describe your changes here:
The interface for the coming element ref coord functions. The function gets a set of reference coordinates inside an element $[0, 1]^d$ and maps these coordinates to the reference coordinates of the tree $[0, 1]^d$, regarding the anchor coordinate, level and orientation. This way, we can evaluate the geometry of arbitrary points inside an element. Before, we could only evaluate the vertices of the elements.

All these boxes must be checked by the reviewers before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

  • The author added a BSD statement to doc/ (or already has one)

  • The code compiles without warning in debugging and release mode, with and without MPI (this should be executed automatically in a github action)

    If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

    • Should this use case be added to the github action?
    • If not, does the specific use case compile and all tests pass (check manually)
  • All tests pass (in various configurations, this should be executed automatically in a github action)

  • New source/header files are properly added to the Makefiles

  • New Datatypes are added to t8indent_custom_datatypes.txt

  • The reviewer executed the new code features at least once and checked the results manually

  • The code is covered in an existing or new test case

  • New tests use the Google Test framework

  • The code follows the t8code coding guidelines

  • The code is well documented

  • All function declarations, structs/classes and their members have a proper doxygen documentation

  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue)

  • If a new directory with source-files is added, it must be covered by the script/find_all_source_files.scp to check the indentation of these files.

  • If this PR introduces a new feature, it must be covered in an example/tutorial and a Wiki article.

@sandro-elsweijer sandro-elsweijer added enhancement Enhances already existing code draft Enhance the visibility that this is a draft. labels Apr 12, 2023
@sandro-elsweijer sandro-elsweijer self-assigned this Apr 12, 2023
@sandro-elsweijer sandro-elsweijer changed the title Feature puma patches [1/x] add element ref coors interface Feature puma patches [2/x] add element ref coors interface Apr 12, 2023
@sandro-elsweijer sandro-elsweijer changed the title Feature puma patches [2/x] add element ref coors interface Feature puma patches [2/x] add element ref coords interface Apr 12, 2023
Base automatically changed from feature-puma_patches_refactoring to main April 13, 2023 13:40
@sandro-elsweijer sandro-elsweijer removed their assignment Apr 13, 2023
@sandro-elsweijer sandro-elsweijer removed the draft Enhance the visibility that this is a draft. label Apr 13, 2023
@sandro-elsweijer sandro-elsweijer marked this pull request as ready for review April 13, 2023 14:07
@sandro-elsweijer sandro-elsweijer added the shouldn't take long Can be resolved in under 30 mins label Apr 13, 2023
@ililikakis ililikakis requested a review from jmark April 17, 2023 13:52
jmark
jmark previously approved these changes Apr 24, 2023
@jmark jmark enabled auto-merge April 24, 2023 07:52
@jmark jmark disabled auto-merge April 24, 2023 07:54
@jmark jmark enabled auto-merge April 24, 2023 08:00
@jmark jmark disabled auto-merge April 24, 2023 08:06
@jmark jmark dismissed their stale review April 24, 2023 08:12

I still have to think about it.

@jmark jmark assigned sandro-elsweijer and unassigned jmark Apr 24, 2023
@jmark jmark merged commit 16272a6 into main Apr 24, 2023
@jmark jmark deleted the feature-puma_patches_interface branch April 24, 2023 13:53
jfussbro pushed a commit to jfussbro/t8code that referenced this pull request Jun 27, 2023
…rface

Feature puma patches [2/x] add element ref coords interface
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhances already existing code shouldn't take long Can be resolved in under 30 mins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants