Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 399 - Remove processing of linear geometries for speedup #501

Merged
merged 15 commits into from
Jul 26, 2023

Conversation

jfussbro
Copy link
Contributor

@jfussbro jfussbro commented Apr 3, 2023

Describe your changes here:

Before this PR all geometries were linked to occ geometries (when using curved option) even if they are linear.
This PR skips linear geometries when linking to occ geometries, resulting in a slightly better performance. There is now the posibility to use curved meshes in the time_forest_partition script.

Closes #399

All these boxes must be checked by the reviewers before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

  • The author added a BSD statement to doc/ (or already has one)

  • The code compiles without warning in debugging and release mode, with and without MPI (this should be executed automatically in a github action)

    If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

    • Should this use case be added to the github action?
    • If not, does the specific use case compile and all tests pass (check manually)
  • All tests pass (in various configurations, this should be executed automatically in a github action)

  • New source/header files are properly added to the Makefiles

  • New Datatypes are added to t8indent_custom_datatypes.txt

  • The reviewer executed the new code features at least once and checked the results manually

  • The code is covered in an existing or new test case

  • New tests use the Google Test framework

  • The code follows the t8code coding guidelines

  • The code is well documented

  • All function declarations, structs/classes and their members have a proper doxygen documentation

  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue)

  • If a new directory with source-files is added, it must be covered by the script/find_all_source_files.scp to check the indentation of these files.

  • If this PR introduces a new feature, it must be covered in an example/tutorial and a Wiki article.

Copy link
Collaborator

@sandro-elsweijer sandro-elsweijer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one last request and then we can merge

@sandro-elsweijer sandro-elsweijer added the enhancement Enhances already existing code label May 21, 2023
@jfussbro jfussbro removed their assignment Jun 27, 2023
@chiaraMaHe chiaraMaHe self-assigned this Jun 27, 2023
@sandro-elsweijer
Copy link
Collaborator

I am afraid the reformatting deleted all the changes you made @jfussbro. So the skipping of linear geometries is completely missing now.

@sandro-elsweijer sandro-elsweijer merged commit f2bf6f4 into DLR-AMR:main Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhances already existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove processing of linear geometries for speedup
3 participants