Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature create cmesh from boundary #451

Merged
merged 37 commits into from
May 10, 2023
Merged

Conversation

ililikakis
Copy link
Contributor

@ililikakis ililikakis commented Mar 6, 2023

Describe your changes here:
Added a new function t8_cmesh_new_hypercube_ext() in t8_cmesh_examples.h which creates a hypercube forest with arbitrary boundary coordinates and number of trees in each direction (x, y, z) from one primitive tree class.

A exemplary call could be:

const double boundary_coords[24] = {1,  0,  0,
  4,  0,  0,
  0,  6,  0,
  5,  5,  0,
 -1, -2,  8,
  9,  0, 10,
  0,  8,  9,
 10, 10,  10};

t8_cmesh_t cmesh = t8_cmesh_new_hypercube_ext (T8_ECLASS_HEX, sc_MPI_COMM_WORLD, boundary_coords, 3, 3, 3);

All these boxes must be checked by the reviewers before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

  • The author added a BSD statement to doc/ (or already has one)

  • The code compiles without warning in debugging and release mode, with and without MPI (this should be executed automatically in a github action)

    If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

    • Should this use case be added to the github action?
    • If not, does the specific use case compile and all tests pass (check manually)
  • All tests pass (in various configurations, this should be executed automatically in a github action)

  • New source/header files are properly added to the Makefiles

  • New Datatypes are added to t8indent_custom_datatypes.txt

  • The reviewer executed the new code features at least once and checked the results manually

  • The code is covered in an existing or new test case

  • New tests use the Google Test framework

  • The code follows the t8code coding guidelines

  • The code is well documented

  • All function declarations, structs/classes and their members have a proper doxygen documentation

  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue)

  • If this PR introduces a new feature, it must be covered in an example/tutorial and a Wiki article.

@ililikakis ililikakis marked this pull request as ready for review March 15, 2023 08:19
@Prasanna-Ponnusamy Prasanna-Ponnusamy requested review from jmark and removed request for Prasanna-Ponnusamy May 2, 2023 13:59
@jmark jmark assigned jmark and unassigned Prasanna-Ponnusamy May 2, 2023
@jmark jmark assigned ililikakis and unassigned jmark May 3, 2023
@ililikakis ililikakis assigned jmark and unassigned ililikakis May 4, 2023
@jmark jmark merged commit 8ba4eea into main May 10, 2023
@jmark jmark deleted the feature-create_cmesh_from_boundary branch May 10, 2023 09:04
jfussbro pushed a commit to jfussbro/t8code that referenced this pull request Jun 27, 2023
…_boundary

Feature create cmesh from boundary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants