Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce test timing #1097

Merged
merged 3 commits into from
Jun 21, 2024
Merged

Reduce test timing #1097

merged 3 commits into from
Jun 21, 2024

Conversation

Davknapp
Copy link
Collaborator

@Davknapp Davknapp commented Jun 20, 2024

Split the hypercube_pad tests into two, to reduce the number of tests run in our testsuite.

All these boxes must be checked by the reviewers before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

  • The reviewer executed the new code features at least once and checked the results manually

  • The code follows the t8code coding guidelines

  • New source/header files are properly added to the Makefiles

  • The code is well documented

  • All function declarations, structs/classes and their members have a proper doxygen documentation

  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue)

Tests

  • The code is covered in an existing or new test case using Google Test

Github action

  • The code compiles without warning in debugging and release mode, with and without MPI (this should be executed automatically in a github action)

  • All tests pass (in various configurations, this should be executed automatically in a github action)

    If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

    • Should this use case be added to the github action?
    • If not, does the specific use case compile and all tests pass (check manually)

Scripts and Wiki

  • If a new directory with source-files is added, it must be covered by the script/find_all_source_files.scp to check the indentation of these files.
  • If this PR introduces a new feature, it must be covered in an example/tutorial and a Wiki article.

Licence

  • The author added a BSD statement to doc/ (or already has one)

Davknapp added 2 commits June 20, 2024 14:09
therefore instead of multiplying by 8 it roughly adds 8 tests
@Davknapp Davknapp changed the title Increase timeout-minutes Reduce test timing Jun 21, 2024
@lukasdreyer lukasdreyer self-assigned this Jun 21, 2024
@lukasdreyer
Copy link
Collaborator

Please update the PR description and include a comment in t8_cmesh_new_hypercube_pad.hxx, that the cmeshes for periodic boundaries are only created for the smallest size to maintain the number of testcases at a reasonable size.

@lukasdreyer lukasdreyer assigned Davknapp and unassigned lukasdreyer Jun 21, 2024
@Davknapp Davknapp requested a review from lukasdreyer June 21, 2024 10:24
@Davknapp Davknapp assigned lukasdreyer and Davknapp and unassigned Davknapp and lukasdreyer Jun 21, 2024
@Davknapp Davknapp assigned lukasdreyer and unassigned Davknapp Jun 21, 2024
@lukasdreyer lukasdreyer merged commit d379371 into main Jun 21, 2024
10 checks passed
@lukasdreyer lukasdreyer deleted the increase_workflow-runtime branch June 21, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants