Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix most of cmesh_copy #1087

Merged
merged 7 commits into from
Jun 27, 2024
Merged

Fix most of cmesh_copy #1087

merged 7 commits into from
Jun 27, 2024

Conversation

lukasdreyer
Copy link
Collaborator

@lukasdreyer lukasdreyer commented Jun 18, 2024

Describe your changes here:
Fixes most of the problems that made the cmesh_copy_test fail.

All these boxes must be checked by the reviewers before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

  • The reviewer executed the new code features at least once and checked the results manually

  • The code follows the t8code coding guidelines

  • New source/header files are properly added to the Makefiles

  • The code is well documented

  • All function declarations, structs/classes and their members have a proper doxygen documentation

  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue)

Tests

  • The code is covered in an existing or new test case using Google Test

Github action

  • The code compiles without warning in debugging and release mode, with and without MPI (this should be executed automatically in a github action)

  • All tests pass (in various configurations, this should be executed automatically in a github action)

    If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

    • Should this use case be added to the github action?
    • If not, does the specific use case compile and all tests pass (check manually)

Scripts and Wiki

  • If a new directory with source-files is added, it must be covered by the script/find_all_source_files.scp to check the indentation of these files.
  • If this PR introduces a new feature, it must be covered in an example/tutorial and a Wiki article.

Licence

  • The author added a BSD statement to doc/ (or already has one)

@lukasdreyer lukasdreyer changed the title start fixing cmesh copy Fix most of cmesh_copy Jun 20, 2024
@lukasdreyer lukasdreyer marked this pull request as ready for review June 20, 2024 09:58
@lukasdreyer lukasdreyer requested a review from Davknapp June 24, 2024 13:10
Copy link
Collaborator

@Davknapp Davknapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you write, that most of cmesh_copy is fixed by this, what is missing?

@lukasdreyer
Copy link
Collaborator Author

you write, that most of cmesh_copy is fixed by this, what is missing?

There was still a problem with partitioned cmeshes, which currently disjoint_bricks is the only one in our testsuite. I investigated further and found wrong usage of sc_shmem_memcpy. So now, all of cmesh copy is fixed.

@Davknapp Davknapp merged commit 07bffa6 into main Jun 27, 2024
10 checks passed
@Davknapp Davknapp deleted the fix_cmesh-copy branch June 27, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants