Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(route): add 机核网资讯 #18220

Merged
merged 2 commits into from
Jan 27, 2025
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
refactor: Use alternative loop instead of reduce for readability
  • Loading branch information
nczitzk committed Jan 27, 2025
commit e4d9064819cc92ae9f112e2a19af9c362a4fb3aa
2 changes: 1 addition & 1 deletion lib/routes/gcores/news.ts
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ export const handler = async (ctx: Context): Promise<Data> => {
let processedItem: DataItem = {
title,
pubDate: pubDate ? parseDate(pubDate) : undefined,
link: linkUrl ? new URL(linkUrl, baseUrl).href : undefined,
link: linkUrl,
category: categories,
author: authors,
guid,
Expand Down
53 changes: 25 additions & 28 deletions lib/routes/gcores/util.ts
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ const parseBlock = (block: Block, entityMap: { [key: string]: Entity }): string
};

/**
* Parses a Content object into an HTML string.
* Parses a Content object into an HTML string using a for loop.
* @param content The Content object to parse.
* @returns The parsed HTML string.
*/
Expand All @@ -198,47 +198,44 @@ const parseContent = (content: Content): string => {
return '';
}

/**
* Accumulator for the reduce operation.
* @property html - Accumulated HTML string.
* @property currentParent - Current parent element tag name (e.g., 'ul', 'ol').
* @property parentContent - Content within the current parent element.
*/
interface ReduceAcc {
html: string;
currentParent: string | undefined;
parentContent: string;
}

const initialAcc: ReduceAcc = { html: '', currentParent: undefined, parentContent: '' };
let html = '';
let currentParent: string | undefined = undefined;
let parentContent = '';

const finalResult = blocks.reduce((acc: ReduceAcc, block) => {
for (const block of blocks) {
const blockType = BLOCK_TYPES[block.type];
if (!blockType) {
return acc;
continue;
}

const parentElement = blockType.parentElement;
const parsedBlock = parseBlock(block, entityMap);

if (parentElement) {
if (acc.currentParent === parentElement) {
// Same parent, append to parent content.
return { ...acc, parentContent: acc.parentContent + parsedBlock };
if (currentParent === parentElement) {
parentContent += parsedBlock;
} else {
// Different parent, close previous parent and open new one.
const closedParent = acc.currentParent ? `<${acc.currentParent}>${acc.parentContent}</${acc.currentParent}>` : '';
return { html: acc.html + closedParent, currentParent: parentElement, parentContent: parsedBlock };
if (currentParent) {
html += `<${currentParent}>${parentContent}</${currentParent}>`;
}
currentParent = parentElement;
parentContent = parsedBlock;
}
} else {
// No parent, close previous parent and append the block.
const closedParent = acc.currentParent ? `<${acc.currentParent}>${acc.parentContent}</${acc.currentParent}>` : '';
return { html: acc.html + closedParent + parsedBlock, currentParent: undefined, parentContent: '' };
if (currentParent) {
html += `<${currentParent}>${parentContent}</${currentParent}>`;
currentParent = undefined;
parentContent = '';
}
html += parsedBlock;
}
}, initialAcc);
}

if (currentParent) {
html += `<${currentParent}>${parentContent}</${currentParent}>`;
}

// Close the last parent tag if any.
return finalResult.currentParent ? finalResult.html + `<${finalResult.currentParent}>${finalResult.parentContent}</${finalResult.currentParent}>` : finalResult.html;
return html;
};

export { parseContent };
Loading