feat: patch job metadata endpoint #397
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryuwd
force-pushed
the
roneil-jobstateupdatehandler
branch
2 times, most recently
from
052332b to
d2106a3
Compare
[pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci add policy Missing awaits and return results adjust returned output Fixed mypy mypy false positive? [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci and line 34 regenerated client
[pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci
ryuwd
force-pushed
the
roneil-jobstateupdatehandler
branch
2 times, most recently
from
7314db4 to
328cf93
Compare
Remove breakpoint pre-commit
ryuwd
force-pushed
the
roneil-jobstateupdatehandler
branch
from
328cf93 to
46559f7
Compare
chrisburr
reviewed
Feb 11, 2025
| with tempfile.TemporaryFile(mode="w+b") as tar_fh: | ||
| with tarfile.open(fileobj=tar_fh, mode=f"w|{SANDBOX_COMPRESSION}") as tf: | ||
| with tempfile.TemporaryFile(mode="w+b") as tar_fh: # type: ignore | ||
| with tarfile.open(fileobj=tar_fh, mode=f"w|{SANDBOX_COMPRESSION}") as tf: # type: ignore |
There was a problem hiding this comment.
@chaen I think you came up with a solution for this?
There was a problem hiding this comment.
yes, I'll finish my PR tomorrow and then you can just rebase
chrisburr
reviewed
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo:
PATCH /metadata/searchCloses #162