Fix up some synthetic tests that never made sense

These had multiple synthetics attached to a vehicle. We made this association unique so test setup broke
DIMO-Network · Jan 8, 2025 · 0f1bb75 · 0f1bb75
1 parent c1904a8
commit 0f1bb75
Showing 1 changed file with 22 additions and 9 deletions.
diff --git a/internal/repositories/synthetic/synthetic_devices_test.go b/internal/repositories/synthetic/synthetic_devices_test.go
@@ -75,6 +75,7 @@ type SyntheticTestSuite struct {
 	honda      models.Manufacturer
 	vehicle1   models.Vehicle
 	vehicle2   models.Vehicle
+	vehicle3   models.Vehicle
 	synthetic1 models.SyntheticDevice
 	synthetic2 models.SyntheticDevice
 	synthetic3 models.SyntheticDevice
@@ -100,9 +101,9 @@ func (s *SyntheticTestSuite) SetupSuite() {
 	// Create test data
 	currTime := time.Now().UTC().Truncate(time.Second)
 
-	_, vehicle1Owner, err := helpers.GenerateWallet()
+	_, vehicle1And2Owner, err := helpers.GenerateWallet()
 	s.Require().NoError(err)
-	_, vehicle2Owner, err := helpers.GenerateWallet()
+	_, vehicle3Owner, err := helpers.GenerateWallet()
 	s.Require().NoError(err)
 	_, synthetic1Addr, err := helpers.GenerateWallet()
 	s.Require().NoError(err)
@@ -114,20 +115,20 @@ func (s *SyntheticTestSuite) SetupSuite() {
 	s.toyota = models.Manufacturer{
 		ID:    131,
 		Name:  "Toyota",
-		Owner: vehicle1Owner.Bytes(),
+		Owner: vehicle1And2Owner.Bytes(),
 		Slug:  "toyota",
 	}
 
 	s.honda = models.Manufacturer{
 		ID:    48,
 		Name:  "Honda",
-		Owner: vehicle2Owner.Bytes(),
+		Owner: vehicle1And2Owner.Bytes(),
 		Slug:  "honda",
 	}
 
 	s.vehicle1 = models.Vehicle{
 		ID:             1,
-		OwnerAddress:   vehicle1Owner.Bytes(),
+		OwnerAddress:   vehicle1And2Owner.Bytes(),
 		ManufacturerID: 131,
 		Make:           toyota,
 		Model:          tacoma,
@@ -138,7 +139,17 @@ func (s *SyntheticTestSuite) SetupSuite() {
 	s.vehicle2 = models.Vehicle{
 		ManufacturerID: 48,
 		ID:             2,
-		OwnerAddress:   vehicle2Owner.Bytes(),
+		OwnerAddress:   vehicle1And2Owner.Bytes(),
+		Make:           honda,
+		Model:          civic,
+		Year:           year2020,
+		MintedAt:       currTime,
+	}
+
+	s.vehicle3 = models.Vehicle{
+		ManufacturerID: 48,
+		ID:             3,
+		OwnerAddress:   vehicle3Owner.Bytes(),
 		Make:           honda,
 		Model:          civic,
 		Year:           year2020,
@@ -156,15 +167,15 @@ func (s *SyntheticTestSuite) SetupSuite() {
 	s.synthetic2 = models.SyntheticDevice{
 		ID:            2,
 		IntegrationID: 2,
-		VehicleID:     s.vehicle1.ID,
+		VehicleID:     s.vehicle2.ID,
 		DeviceAddress: synthetic2Addr.Bytes(),
 		MintedAt:      currTime,
 	}
 
 	s.synthetic3 = models.SyntheticDevice{
 		ID:            3,
 		IntegrationID: 1,
-		VehicleID:     s.vehicle2.ID,
+		VehicleID:     s.vehicle3.ID,
 		DeviceAddress: synthetic3Addr.Bytes(),
 		MintedAt:      currTime,
 	}
@@ -194,6 +205,8 @@ func (s *SyntheticTestSuite) Test_GetSyntheticDevices() {
 	s.Require().NoError(err)
 	err = s.vehicle2.Insert(ctx, s.pdb.DBS().Writer, boil.Infer())
 	s.Require().NoError(err)
+	err = s.vehicle3.Insert(ctx, s.pdb.DBS().Writer, boil.Infer())
+	s.Require().NoError(err)
 	err = s.synthetic1.Insert(ctx, s.pdb.DBS().Writer, boil.Infer())
 	s.Require().NoError(err)
 	err = s.synthetic2.Insert(ctx, s.pdb.DBS().Writer, boil.Infer())
@@ -250,7 +263,7 @@ func (s *SyntheticTestSuite) Test_GetSyntheticDevices() {
 			last: Ptr(2),
 		},
 		{
-			name: "Filter by vehicle",
+			name: "Filter by owner",
 			filter: &gmodel.SyntheticDevicesFilter{
 				Owner: Ptr(common.BytesToAddress(s.vehicle1.OwnerAddress)),
 			},