Initial SDK Review #1
Conversation
README.md
Outdated
| Please visit the DIMO [Developer Documentation](https://docs.Dimo.zone/developer-platform) to learn more about building on DIMO and detailed information on the API. | ||
|
|
||
| ### Developer License |
There was a problem hiding this comment.
Let's update this to something similar to the NodeJS one with DevConsole https://github.com/DIMO-Network/dimo-node-sdk?tab=readme-ov-file#developer-registration
README.md
Outdated
| .AddRestServices() | ||
| .AddGraphQLServices() | ||
| .AddStreamr() |
There was a problem hiding this comment.
Do we want to include this now?
README.md
Outdated
| #### Prerequisites for Authentication | ||
|
|
||
| 1. A valid Developer License. |
There was a problem hiding this comment.
Let's also change this part according to https://github.com/DIMO-Network/dimo-node-sdk?tab=readme-ov-file#prerequisites-for-authentication
|
Assigning this over to @JamesReate for C# code reviews. |
|
I've updated the PR according to the comments @jamesliupenn @JamesReate |
| ___ | ||
|
|
||
| #### Device Data API |
There was a problem hiding this comment.
Should this be the Telemetry GraphQL instead now?
There was a problem hiding this comment.
I think I will need to change to another example like on node sdk: https://github.com/DIMO-Network/dimo-node-sdk?tab=readme-ov-file#querying-the-dimo-rest-api
There was a problem hiding this comment.
I think this is a good first take on this. But I'm sure we'll need to take another pass at it as real developers start playing with it.
Thoughts:
I am unsure of including API wrappers for all the endpoints in devices-api, eg. smartcar or tesla specific things. Same for vehicle signal decoding. Device definitions api also in theory external developers wouldn't need since all that stuff should be available via identity-api.
Adding some comments in some of the services files may also be good - if these are auto-generated from swagger maybe could auto bring in the comments from swagger.
No description provided.