EX-3119-cio-disconn-event #441
Open
+233
−92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinJoiner
requested changes
Jan 30, 2025
elffjs
requested changes
Feb 1, 2025
elffjs
requested changes
Feb 4, 2025
elffjs
reviewed
Feb 4, 2025
elffjs
reviewed
Feb 4, 2025
elffjs
reviewed
Feb 4, 2025
internal/services/cio/cio.go
Outdated
Comment on lines
49
to
51
| if !common.IsHexAddress(userAddr.Hex()) { | ||
| return fmt.Errorf("invalid ethereum_address %s", userAddr.Hex()) | ||
| } |
There was a problem hiding this comment.
I think there's no danger of this happening. If you wanted to be really, really careful you could check that udai.R.UserDevice.OwnerAddress.Bytes really has length 20, but I think the database will enforce that if it's populated so I think it's not too scary.
There was a problem hiding this comment.
okay cool, removed it in that case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Impacted Routes
Caveats