Delete AutoPiTaskService, which isn't used anywhere anymore once /upd… #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I thought we used the autopi task service to set the template? |
I'm not super familiar with how that works, but the only other task available on this struct is Template association seems to be a plain call with no identifier or anything attached. Maybe we get a callback of some sort? @JamesReate could you chime in? |
|
@JamesReate Giving this a nudge. |
JamesReate
approved these changes
May 31, 2024
JamesReate
reviewed
May 31, 2024
| @@ -46,7 +47,6 @@ require ( | |||
| github.com/swaggo/swag v1.16.3 | |||
| github.com/testcontainers/testcontainers-go v0.27.0 | |||
| github.com/tidwall/gjson v1.17.0 | |||
| github.com/vmihailenco/taskq/v3 v3.2.8 | |||
|
yeah this is good to remove - was only used to apply the update and keep track of that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ate is gone
I wish this meant that we could kill Redis but alas.
We can, however, get rid of our forked version of taskq.