Delete teslaAuth tokens from cache after persisting to kafka and db #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…akeUpVehicle for new fleet API, generate swagger schema
elffjs
approved these changes
Feb 29, 2024
| if apiVersion == constants.TeslaAPIV2 { // If version is 2, we are using fleet api which has token stored in cache | ||
| deviceIntReq, err := udc.getTeslaAuthFromCache(c.Context(), ud.UserID) | ||
| user, err := udc.usersClient.GetUser(c.Context(), &pb.GetUserRequest{Id: ud.UserID}) |
There was a problem hiding this comment.
Okay, we're moving this up in order to provide nicer messages.
There was a problem hiding this comment.
Not really, Its because I need the cache key for deletion and its formed using the user eth address. But that is also a good point, I will use it.
Base automatically changed from
feature/si-2449-promote-stored-access-token-credentials
to
main
February 29, 2024 20:47
KevinJoiner
approved these changes
Feb 29, 2024
| if apiVersion == constants.TeslaAPIV2 { // If version is 2, we are using fleet api which has token stored in cache | ||
| deviceIntReq, err := udc.getTeslaAuthFromCache(c.Context(), ud.UserID) | ||
| user, err := udc.usersClient.GetUser(c.Context(), &pb.GetUserRequest{Id: ud.UserID}) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Impacted Routes
Caveats