SI-2213-amd-addr-reset-event #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allyson-English
commented
Dec 13, 2023
elffjs
reviewed
Dec 13, 2023
elffjs
reviewed
Dec 13, 2023
elffjs
reviewed
Dec 13, 2023
elffjs
reviewed
Dec 18, 2023
Co-authored-by: Dylan Moreland <[email protected]>
elffjs
reviewed
Dec 19, 2023
Comment on lines
710
to
711
| SET ethereum_address = decode('%s', 'hex') | ||
| WHERE token_id = %d;`, |
There was a problem hiding this comment.
Could we use ? or $1 or something for these? Is that allowed? I think it's less alarming that way.
There was a problem hiding this comment.
I always have to check that decode is being used correctly. I think it is.
elffjs
reviewed
Dec 20, 2023
| @@ -689,6 +693,30 @@ func (c *ContractsEventsConsumer) dcnNewExpiration(e *ContractEventData) error { | |||
| return nil | |||
| } | |||
|
|
|||
| // $1 is the updated aftermarket device address, $2 is the token id | |||
| const aftermarketDeviceAddressResetQuery = ` | |||
There was a problem hiding this comment.
I'm kinda happier to have this inline. Is that picky?
elffjs
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an AftermarketDeviceAddressReset event is received, update the 0x address of the device to reflect the change
Notes: