Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SI-2176-preload-jsonld-vc-issuer-2 #229

Merged
merged 3 commits into from
Nov 30, 2023
Merged

Conversation

Allyson-English
Copy link
Member

this proposes a way to keep schema.org included in our @context

Copy link

linear bot commented Nov 21, 2023

SI-2176 Preload VC issuer with JSON-LD documents

loading remote context failed: Dereferencing a URL did not result in a valid JSON-LD context: https://www.w3.org/2018/credentials/v1

Our calls to get JSON-LD documents to construct the VC are failing. It would be best if we didn't have to rely at all on network calls.

  • Which documents are we loading?
  • How can we pre-load these in the app? Ideally, we can use //go:embed.
  • Execute

@elffjs
Copy link
Member

elffjs commented Nov 30, 2023

I don't really know what this is doing. Is it mergeable? I'm open to trying it.

@Allyson-English
Copy link
Member Author

yeah, this was just a way for us to keep our reference to schema.org, it's mergeable!

@Allyson-English Allyson-English marked this pull request as ready for review November 30, 2023 21:07
@elffjs elffjs merged commit 48b8708 into main Nov 30, 2023
2 checks passed
@elffjs elffjs deleted the SI-2176-preload-jsonld-vc-issuer-2 branch November 30, 2023 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants