Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO-TASK] conform to new API function signatures #53

Merged
merged 1 commit into from
Aug 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 28 additions & 10 deletions packages/react/src/contexts/payment-routes.context.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,18 @@ interface PaymentRoutesInterface {
paymentRoutesLoading: boolean;
paymentLinksLoading: boolean;
createPaymentLink: (request: CreatePaymentLink) => Promise<PaymentLink | undefined>;
updatePaymentLink: (request: UpdatePaymentLink, id?: number, externalId?: string) => Promise<void>;
createPaymentLinkPayment: (request: CreatePaymentLinkPayment, id?: number, externalId?: string) => Promise<void>;
cancelPaymentLinkPayment: (id?: number, externalId?: string) => Promise<void>;
updatePaymentLink: (
request: UpdatePaymentLink,
linkId?: string,
externalLinkId?: string,
externalPaymentId?: string,
) => Promise<void>;
createPaymentLinkPayment: (
request: CreatePaymentLinkPayment,
linkId?: string,
externalLinkId?: string,
) => Promise<void>;
cancelPaymentLinkPayment: (linkId?: string, externalLinkId?: string, externalPaymentId?: string) => Promise<void>;
deletePaymentRoute: (id: number, type: PaymentRouteType) => Promise<void>;
error?: string;
}
Expand Down Expand Up @@ -72,33 +81,42 @@ export function PaymentRoutesContextProvider(props: PropsWithChildren): JSX.Elem
}
}

async function updatePaymentLink(request: UpdatePaymentLink, id?: number, externalId?: string): Promise<void> {
async function updatePaymentLink(
request: UpdatePaymentLink,
linkId?: string,
externalLinkId?: string,
externalPaymentId?: string,
): Promise<void> {
if (!user) return;

setPaymentLinksLoading(true);
return updatePaymentLinkApi(request, id, externalId)
return updatePaymentLinkApi(request, linkId, externalLinkId, externalPaymentId)
.then(updatePaymentLinks)
.finally(() => setPaymentLinksLoading(false));
}

async function createPaymentLinkPayment(
request: CreatePaymentLinkPayment,
id?: number,
externalId?: string,
linkId?: string,
externalLinkId?: string,
): Promise<void> {
if (!user) return;

setPaymentLinksLoading(true);
return createPaymentLinkPaymentApi(request, id, externalId)
return createPaymentLinkPaymentApi(request, linkId, externalLinkId)
.then(updatePaymentLinks)
.finally(() => setPaymentLinksLoading(false));
}

async function cancelPaymentLinkPayment(id?: number, externalId?: string): Promise<void> {
async function cancelPaymentLinkPayment(
linkId?: string,
externalLinkId?: string,
externalPaymentId?: string,
): Promise<void> {
if (!user) return;

setPaymentLinksLoading(true);
return cancelPaymentLinkPaymentApi(id, externalId)
return cancelPaymentLinkPaymentApi(linkId, externalLinkId, externalPaymentId)
.then(updatePaymentLinks)
.finally(() => setPaymentLinksLoading(false));
}
Expand Down
54 changes: 40 additions & 14 deletions packages/react/src/hooks/payment-routes.hook.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,28 @@ import {

export interface PaymentRoutesInterface {
getPaymentRoutes: () => Promise<PaymentRoutes>;
getPaymentLinks: (id?: number, externalId?: string) => Promise<PaymentLink | PaymentLink[]>;
getPaymentLinks: (
linkId?: string,
externalLinkId?: string,
externalPaymentId?: string,
) => Promise<PaymentLink | PaymentLink[]>;
createPaymentLink: (request: CreatePaymentLink) => Promise<PaymentLink>;
updatePaymentLink: (request: UpdatePaymentLink, id?: number, externalId?: string) => Promise<PaymentLink>;
updatePaymentLink: (
request: UpdatePaymentLink,
linkId?: string,
externalLinkId?: string,
externalPaymentId?: string,
) => Promise<PaymentLink>;
createPaymentLinkPayment: (
request: CreatePaymentLinkPayment,
id?: number,
externalId?: string,
linkId?: string,
externalLinkId?: string,
) => Promise<PaymentLink>;
cancelPaymentLinkPayment: (
linkId?: string,
externalLinkId?: string,
externalPaymentId?: string,
) => Promise<PaymentLink>;
cancelPaymentLinkPayment: (id?: number, externalId?: string) => Promise<PaymentLink>;
deletePaymentRoute: (id: number, type: PaymentRouteType) => Promise<PaymentRoute>;
}

Expand All @@ -34,8 +47,12 @@ export function usePaymentRoutes(): PaymentRoutesInterface {
return call<PaymentRoutes>({ url: PaymentRoutesUrl.get, method: 'GET' });
}

async function getPaymentLinks(id?: number, externalId?: string): Promise<PaymentLink | PaymentLink[]> {
const queryParams = Utils.buildQueryParams({ id, externalId });
async function getPaymentLinks(
linkId?: string,
externalLinkId?: string,
externalPaymentId?: string,
): Promise<PaymentLink | PaymentLink[]> {
const queryParams = Utils.buildQueryParams({ linkId, externalLinkId, externalPaymentId });

return call<PaymentLink | PaymentLink[]>({
url: `${PaymentLinksUrl.get}?${queryParams}`,
Expand All @@ -51,8 +68,13 @@ export function usePaymentRoutes(): PaymentRoutesInterface {
});
}

async function updatePaymentLink(request: UpdatePaymentLink, id?: number, externalId?: string): Promise<PaymentLink> {
const queryParams = Utils.buildQueryParams({ id, externalId });
async function updatePaymentLink(
request: UpdatePaymentLink,
linkId?: string,
externalLinkId?: string,
externalPaymentId?: string,
): Promise<PaymentLink> {
const queryParams = Utils.buildQueryParams({ linkId, externalLinkId, externalPaymentId });

return call({
url: `${PaymentLinksUrl.update}?${queryParams}`,
Expand All @@ -63,10 +85,10 @@ export function usePaymentRoutes(): PaymentRoutesInterface {

async function createPaymentLinkPayment(
request: CreatePaymentLinkPayment,
id?: number,
externalId?: string,
linkId?: string,
externalLinkId?: string,
): Promise<PaymentLink> {
const queryParams = Utils.buildQueryParams({ id, externalId });
const queryParams = Utils.buildQueryParams({ linkId, externalLinkId });

return call<PaymentLink>({
url: `${PaymentLinksUrl.payment}?${queryParams}`,
Expand All @@ -75,8 +97,12 @@ export function usePaymentRoutes(): PaymentRoutesInterface {
});
}

async function cancelPaymentLinkPayment(id?: number, externalId?: string): Promise<PaymentLink> {
const queryParams = Utils.buildQueryParams({ id, externalId });
async function cancelPaymentLinkPayment(
linkId?: string,
externalLinkId?: string,
externalPaymentId?: string,
): Promise<PaymentLink> {
const queryParams = Utils.buildQueryParams({ linkId, externalLinkId, externalPaymentId });

return call<PaymentLink>({
url: `${PaymentLinksUrl.payment}?${queryParams}`,
Expand Down
Loading