Initial modification of how configs are handled for stonesense #120
Conversation
Stonesense configs are now in the dfhack-configs folder when installed but the actual files are all in the stonesense repo.
|
dont merge til i add changelog stuff btw, unless i should still make a seperate pr (doubtful) |
|
Is there any more we need to do on this or can we get it merged? I'm hoping to start work on my larger config changes soon |
Co-authored-by: Alan <[email protected]>
dont merge, i need toi fix the docs too
|
should i update the docs or make a fresh PR for that? edit: nvm i forgot which repo i was in |
|
ok now im actually finished. ready to be merged if no other issues are found |
Remember, with We try to get to PRs expediently, but our life schedules don't always allow it. Small PRs can go through quickly, but larger or contentious PRs can take much longer. Patience is appreciated. |
configs/stonesense/init.txt
Outdated
There was a problem hiding this comment.
I think Lethosor mentioned this -- the file would make more sense as configs/init.txt -- there's no need to duplicate the stonesense path in this repo. As written, I think the file will end up as data/dfhack-config-defaults/stonesense/stonesense/init.txt
There was a problem hiding this comment.
nope i changed it awhile back and it does ...defaults/stonesense/init.txt
There was a problem hiding this comment.
ignore config.json im testing a sub branch of this one
There was a problem hiding this comment.
actually wait thy're both outdated
There was a problem hiding this comment.
i'm missing a commit, hang on thx for catching that
Co-authored-by: Myk <[email protected]>
|
should be fixed? hopefully? |
Stonesense configs are now in the dfhack-configs folder when installed but the actual files are here in the stonesense repo