[856] Update production checklist #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aje54
reviewed
Jan 28, 2025
There was a problem hiding this comment.
Line 69: "It requires creating a monitoring action group. The new_service template includes the make action-group command to automate this task. Ask the infra team to set it up.” - suggest adding a short explanation of why they would do this? what does it give them?
line 146 : "To help in this occasion, document for each secret:” - suggest being more explicit on what you want for this? document what exactly - and where?
Add: - caching - redirects - docker pinning - documenting secrets - postgres/redis monitoring clarification
saliceti
force-pushed
the
856-add-to-production-checklist
branch
from
d7e6389 to
fc3cf48
Compare
aje54
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Capture more good practices in the doc
Changes proposed in this pull request
Add:
Guidance to review
Review documentation
Checklist
Devopslabel