Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Correcting RBAC errors #354

Merged
merged 1 commit into from
Jan 16, 2025
Merged

feat: Correcting RBAC errors #354

merged 1 commit into from
Jan 16, 2025

Conversation

shaheislamdfe
Copy link
Contributor

@shaheislamdfe shaheislamdfe commented Jan 16, 2025 •
edited
Loading

Context

Correcting namespace for reloader and adding RBAC permissions

Changes proposed in this pull request

Changing namespace to monitoring and adding RBAC for cronjobs API

Guidance to review

Check logs for pod and namespace
Screenshot 2025-01-16 at 13 13 17

Checklist

  • I have performed a self-review of my code, including formatting and typos
  • I have cleaned the commit history
  • I have added the Devops label
  • I have attached the pull request to the trello card

vipin-dfe
vipin-dfe approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@vipin-dfe vipin-dfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shaheislamdfe shaheislamdfe merged commit 14f724c into main Jan 16, 2025
6 checks passed
@shaheislamdfe shaheislamdfe deleted the 1715-alertmanager-config-reloader-container-fix branch January 16, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vipin-dfe vipin-dfe vipin-dfe approved these changes

Assignees
No one assigned
Labels
DevOps
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shaheislamdfe @vipin-dfe