Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SASSC gem #3723

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Remove SASSC gem #3723

merged 1 commit into from
Jul 18, 2023

Conversation

inulty-dfe
Copy link
Contributor

@inulty-dfe inulty-dfe commented Jul 12, 2023

Context

The gem was added because the 2.10.0 release of better_errors broke
the build. A new release 2.10.1 fixed the issue and SASSC is no longer
needed in the application.

The css is compiled and included in the built gem.

Breaking Change: BetterErrors/better_errors#498
Fix: BetterErrors/better_errors#520

Changes proposed in this pull request

Guidance to review

Checklist

  • Make sure all information from the Trello card is in here
  • Attach to Trello card
  • Rebased main
  • Cleaned commit history
  • Tested by running locally
  • Inform data insights team due to database changes

  The gem was added because the 2.10.1 release of better_errors broke
  the build. A new release 2.10.1 fixed the issue and SASSC is no longer
  needed in the application.

  The css is compiled and included in the built gem.

  Breaking Change: BetterErrors/better_errors#498
  Fix: BetterErrors/better_errors#520
@inulty-dfe inulty-dfe added DO NOT MERGE This PR is not ready to be deployed deploy_v2 and removed DO NOT MERGE This PR is not ready to be deployed labels Jul 12, 2023
@inulty-dfe inulty-dfe requested a review from a team July 13, 2023 15:19
@inulty-dfe inulty-dfe merged commit 083fcf7 into main Jul 18, 2023
@inulty-dfe inulty-dfe deleted the remove-sassc branch July 18, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants