Bump rubocop-govuk from 3.3.1 to 3.3.2

[dependabot-preview]

Bumps rubocop-govuk from 3.3.1 to 3.3.2.

Changelog

Sourced from rubocop-govuk's changelog.

3.3.2

• Exclude /tmp directory (#29)

Commits

• a988ac7 Merge pull request #30 from alphagov/version-bump
• 1401729 Release 3.3.2
• ee656d9 Merge pull request #29 from alphagov/exclude-tmp
• e5d6576 Exclude /tmp directory
• See full diff in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
• @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
• @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
• @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
• @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
• @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

• Update frequency (including time of day and day of week)
• Pull request limits (per update run and/or open at any time)
• Automerge options (never/patch/minor, and dev/runtime dependencies)
• Out-of-range updates (receive only lockfile updates, if desired)
• Security updates (receive only security updates, if desired)

[aliuk2012]

@dependabot rebase

[misaka]

There are three errors in the rubocop run, all seem to point to validations of uniqueness that are scoped:

1 course_code Validation in Course

An error occurred while Rails/UniqueValidationWithoutIndex cop was inspecting /app/app/models/course.rb:53:2.

https://github.com/DFE-Digital/teacher-training-api/blob/dependabot/bundler/rubocop-govuk-3.3.2/app/models/course.rb#L53-L55

  validates :course_code,
            uniqueness: { scope: :provider_id },
            on: %i[create update]

2 location_name Validation in Site

An error occurred while Rails/UniqueValidationWithoutIndex cop was inspecting /app/app/models/site.rb:43:2.

https://github.com/DFE-Digital/teacher-training-api/blob/dependabot/bundler/rubocop-govuk-3.3.2/app/models/site.rb#L43

  validates :location_name, uniqueness: { scope: :provider_id }

3 code Validation in Site

An error occurred while Rails/UniqueValidationWithoutIndex cop was inspecting /app/app/models/site.rb:49:2.

https://github.com/DFE-Digital/teacher-training-api/blob/dependabot/bundler/rubocop-govuk-3.3.2/app/models/site.rb#L49-L51

  validates :code, uniqueness: { scope: :provider_id, case_sensitive: false },
                   inclusion: { in: POSSIBLE_CODES, message: "must be A-Z, 0-9 or -" },
                   presence: true

My feeling is this is probably just a bug in rubocop-govuk ... should probably report it and skip this release. Not sure how the listed change could have this affect.

[aliuk2012]

rubocop/rubocop-rails#222 Might resolve this issue

[dankmitchell]

Closing until they bump. The above PR to fix that has been merged now.

[dependabot-preview]

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.