Allow providers to csv export all their application choices

[CatalinVoineag]

Context

Previously, we allowed providers to only export their applications
choices only from the current and previous cycle

This commit allows them to export every recruitment cycle they have
application choices for.

Changes proposed in this pull request

Application export

Guidance to review

Go on review app, log as a provider and export applications that are at least 3 cycles ago.

The provider NIoT@Harris Initial Teacher Education has 2023 applications to export, 2023, 2 cycles ago was not possible to export.

Things to check

• If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
• This code does not rely on migrations in the same Pull Request
• If this code includes a migration adding or changing columns, it also backfills existing records for consistency
• If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist, if included inform data insights team of the changes
• If this code adds a column that may include PII, the sanitise.sql script and 0025-protecting-personal-data-in-production-dump.md ADR have been updated
• API release notes have been updated if necessary
• If it adds a significant user-facing change, is it documented in the CHANGELOG?
• Attach the PR to the Trello card

[CatalinVoineag]

Expand application data download for all years provider has applications

[elceebee]

This looks great, thanks for adding the line about getting the cycles in the review apps!

One little UI thing: I think it would be better to have the years in reverse order, the current year on top:

But I don't feel strongly about it.

The other thing is I'm not sure about reseeding the timetables in the rails_helper. Right now, you note something as a :feature test, it will automatically sed the timetables and set the current time to mid cycle.

If you set the time on any of the tests using the CycleTimetableHelper (eg mid_cycle), it will make sure there are timetables seeded.

In the rare cases where they are needed and not covered by these scenarios, you can just add seed_timetables in the describe line of a test.

I would prefer this method to using the data migration, because how we seed the timetables will evolve as we stop relying on them being defined in a yml file.

[CatalinVoineag]

This looks great, thanks for adding the line about getting the cycles in the review apps!

One little UI thing: I think it would be better to have the years in reverse order, the current year on top:

But I don't feel strongly about it.

The other thing is I'm not sure about reseeding the timetables in the rails_helper. Right now, you note something as a :feature test, it will automatically sed the timetables and set the current time to mid cycle.

If you set the time on any of the tests using the CycleTimetableHelper (eg mid_cycle), it will make sure there are timetables seeded.

In the rare cases where they are needed and not covered by these scenarios, you can just add seed_timetables in the describe line of a test.

I would prefer this method to using the data migration, because how we seed the timetables will evolve as we stop relying on them being defined in a yml file.

I've reversed sorted the recruitment cycle years b4d00c9

[elceebee]

👍

[elceebee]

Beautiful! So great to have this out so quickly -- a provider only asked for it on Wednesday.