Add Preset parameters to both search parameters classes #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eters.cs and MultiSearchParameters.cs)
runeanielsen
reviewed
Jan 9, 2025
src/Typesense/SearchParameters.cs
Outdated
| [JsonPropertyName("preset")] | ||
| public bool? Preset { get; set; } | ||
|
|
||
|
|
There was a problem hiding this comment.
Can you remove the extra newline to keep the formatting consistent?
|
Looks good, thank you very much for the contribution. @trentstollery-millow |
|
I've released a new version with you changes. 7.23.0 |
|
Nevermind, the NuGet key has expired. I'll make a new release when that has been updated, and I'll let you know. |
|
@trentstollery-millow it has been released now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per Preset Documentation.
Adds the option to use preset search parameters, which can be very useful if you don't want to have to reference query parameters in your search calls.
Can't see any tests that need updating.. but if you want any updated let me know