Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: collect evidences for license #1309
feat: collect evidences for license #1309
Changes from 2 commits
ac8c142
5bf84dc
30d5de9
9906cbf
107d2b7
f32c1c7
7dd053c
6711ad2
4d33603
abe3bc3
1336a1b
1976436
895b1c2
1e84884
1293b13
873006b
9b7b253
e2e44b0
9e41244
d4fd58f
bf5b1d8
b652ae0
f9dede8
796a513
03b0346
b0a5c89
1f987ac
7faf23e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please use only non-capturing groups in that regex
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
variable
typicalFilenameRex
could be a const on file level.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved it, but I am unsure if I understood your comment correctly due to the "group things that depend on eachother." principle you mentioned, that I also prefer over the global declaration.
Check failure on line 147 in src/_helpers.ts
src/_helpers.ts#L147