Fix Mediamarkt ES #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the following error: call_user_func(): Argument Cybrarist#1 ($callback) must be a valid callback, class App\\Helpers\\URLHelper does not have a method \"get_mediamarkt_key\" at /app/app/Helpers/URLHelper.php:64) Signed-off-by: Raphaël Mélotte <[email protected]>
In the case of Mediamarkt es there is only one offer instead of an array. Signed-off-by: Raphaël Mélotte <[email protected]>
|
perfect. i am surprised no one report this issue. i will merge the changes and add test case for it. Thanks for the help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix two typos which should now make it possible to retrieve and track the price for Mediamarkt ES.