Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: CLDN-1928-Adhoc Filter displays as not applied when empty #252

Merged
merged 5 commits into from
Feb 6, 2023
Merged

fix: CLDN-1928-Adhoc Filter displays as not applied when empty #252

merged 5 commits into from
Feb 6, 2023

Conversation

cccs-RyanK
Copy link
Member

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@cccs-RyanK cccs-RyanK changed the title value set to empty list instead of undefined fix: CLDN-1928-Adhoc Filter displays as not applied when empty Feb 3, 2023
@cccs-RyanK cccs-RyanK merged commit aa4db47 into cccs-2.0 Feb 6, 2023
@cccs-RyanK cccs-RyanK deleted the CLDN-1928-filter-incorrectly-displays-as-applied branch February 6, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cccs-RyanS cccs-RyanS cccs-RyanS approved these changes

@cccs-Dustin cccs-Dustin cccs-Dustin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cccs-RyanK @cccs-RyanS @cccs-Dustin