-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore mapbox-gl transpiling #217
Conversation
@justinanderson I think not transpiling Mapbox is still better solution than transpiling Web Worker separately, as they say it significantly increases bundle size and negatively impacts rendering - is only considered if targeting legacy browsers.
|
@torosyaneric But do we require ES5 compatibility? How does this compare with Mapbox's first suggestion to use browserlist? |
@justinanderson it seems the browserslist approach wasn't working as our browserslist value is identical to their suggestion (+ "not op_mini all") |
@torosyaneric Did you see this comment mapbox/mapbox-gl-js#10565 (comment) and the ones referencing it later from the link in the issue? It looks like Mapbox's documentation may need an update. Our production builds work with that modification, |
@justinanderson sorry, missed that one, fixed and pushed. Thanks for mentioning this. |
@torosyaneric But, I mean, what's the difference between the two options? I don't have much experience with transpilation concerns and would like to understand the choice we're making. |
@justinanderson I'm not 100% percent sure but I suppose using browserslist approach prevents the transpilation for whole codebase by rule "supports es6-class" and "import from !mapbox" was just ignoring the mapbox transpilation. I don't think these have advantages in terms of bundle size, maybe in build time. |
@torosyaneric Nah, this is fine. I spent some time to learn about transpilation and feel I understand it well enough now. It looks like we can safely ignore browsers which don't support ES6, so I'll take this as is. |
06ec2df
to
8e6f11c
Compare
Force-pushed to remove noop commit and allow this branch to rebase cleanly. |
Resolves #213