-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the Collection extent to be a 2d array to match the specification #175
Conversation
@dr-jts Hey there! I was curious if you had seen any issue like this before? |
No. But I don't use ArcGIS. Is this valid according to the OGC spec? |
This does look like it's not implemented according to the OGC Features specification. The definition of the
The definition allows multiple extents to be provided for a collection, with the first one being the overall extent (which allows systems to choose to read just one extent). (OGC Features Core issue 518 discusses this.) It's very surprising this bug hasn't turned up until now! Is this really all the changes needed to fix this? Does the UI still work? |
The UI actually did not work with it in a 1D array but it did work in a 2D array just a pic of it working with the 2D array |
Also added a test to confirm the |
I am testing with the OGCFeatureLayer from arcgis Core v4.30.9 and noticed that I was unable to get the features to display on the map. After looking through their library, they are expecting the bbox to be a 2d array. Thus when it tries to pull the bbox and sees that it is a 1d array, it tries to access a float and then errors out.
I updated the type of extent to be a 2d array instead of a 1d array and put the same
Code from the OGCFeatureLayer in arcgis Core v4.30.9