Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider Tailwind 3.x bump #182

Closed
MichalBryxi opened this issue Sep 27, 2022 · 1 comment
Closed

Consider Tailwind 3.x bump #182

MichalBryxi opened this issue Sep 27, 2022 · 1 comment
Labels
released

Comments

@MichalBryxi
Copy link

I believe that current version of this package supports tailwind ^2.2.15. There are some differences between v2 series and v3.

The one annoyance I noticed and why I'm raising this issue is that because when using prettier-plugin-tailwindcss which comes with >= 3.x compatibility, I'm getting:

warn - The `darkMode` option in your Tailwind CSS configuration is set to `false`, which now behaves the same as `media`.
warn - Change `darkMode` to `media` or remove it entirely.
warn - https://tailwindcss.com/docs/upgrade-guide#remove-dark-mode-configuration
MichalBryxi pushed a commit to MichalBryxi/tailwind-toucan-base that referenced this issue Sep 27, 2022
fix(CrowdStrike#182): remove darkMode from config
16ad9c1 
- For tailwind-3.x the config of darkMode [should not be used](https://tailwindcss.com/docs/upgrade-guide)
- It's only annoyance, but when using [prettier-plugin-tailwindcss](https://github.com/tailwindlabs/prettier-plugin-tailwindcss) I get tons of:
> warn - The `darkMode` option in your Tailwind CSS configuration is set to `false`, which now behaves the same as `media`.
> warn - Change `darkMode` to `media` or remove it entirely.
> warn - https://tailwindcss.com/docs/upgrade-guide#remove-dark-mode-configuration
- This PR should ... hopefully fix that
MichalBryxi pushed a commit to MichalBryxi/tailwind-toucan-base that referenced this issue Sep 27, 2022
fix(CrowdStrike#182): remove darkMode from config
cdecd50 
- For tailwind-3.x the config of darkMode
  [should not be used](https://tailwindcss.com/docs/upgrade-guide)
- It's only annoyance, but when using
  [prettier-plugin-tailwindcss](https://github.com/tailwindlabs/prettier-plugin-tailwindcss)
  I get tons of:

> warn - The `darkMode` option in your Tailwind CSS configuration is set to `false`,
> which now behaves the same as `media`.
> warn - Change `darkMode` to `media` or remove it entirely.
> warn - https://tailwindcss.com/docs/upgrade-guide#remove-dark-mode-configuration

- This PR should ... hopefully fix that
NullVoxPopuli added a commit that referenced this issue Sep 27, 2022
@NullVoxPopuli
Merge pull request #183 from MichalBryxi/fix/182-remove-dark-mode-fro…
df56b9b 
…m-config

fix(#182): remove darkMode from config
github-actions bot pushed a commit that referenced this issue Sep 27, 2022
@semantic-release-bot
chore(release): 3.3.1 [skip ci]
2db5e29 
## [3.3.1](v3.3.0...v3.3.1) (2022-09-27)

### Bug Fixes

* **#182:** remove darkMode from config ([cdecd50](cdecd50)), closes [#182](#182)
@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 3.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@NullVoxPopuli @MichalBryxi