Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: remove legacy code #274

Merged
merged 3 commits into from
Apr 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions helm-charts/falcon-sensor/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,12 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 1.26.3
version: 1.27.1

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
# follow Semantic Versioning. They should reflect the version the application is using.
appVersion: 1.26.3
appVersion: 1.27.1

keywords:
- CrowdStrike
Expand Down
6 changes: 2 additions & 4 deletions helm-charts/falcon-sensor/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,8 @@ The Falcon Helm chart has been tested to deploy on the following Kubernetes dist

| Helm chart Version | Falcon Sensor Version |
|:------------------------|:----------------------------------|
| `<= 1.6.x` | `<= 6.34.x` |
| `>= 1.7.x && <= 1.17.x` | `>= 6.35.x && < 6.49.x` |
| `>= 1.18.x` | `>= 6.49.x` |
| `>= 1.19.x` | `>= 6.54.x` |
redhatrises marked this conversation as resolved.
Show resolved Hide resolved
| `<= 1.26.x` | `< 7.05.x` |
| `>= 1.27.x` | `>= 7.06.x` |

# Installation

Expand Down
2 changes: 1 addition & 1 deletion helm-charts/falcon-sensor/templates/container_secret.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ data:
type: kubernetes.io/dockerconfigjson
{{- if or .Values.container.image.pullSecrets.namespaces .Values.container.image.pullSecrets.allNamespaces }}
{{- $name := ( .Values.container.image.pullSecrets.name | default (printf "%s-pull-secret" (include "falcon-sensor.fullname" .))) }}
{{- $myns := split "," .Values.container.image.pullSecrets.namespaces -}}
{{- $myns := split "," .Values.container.image.pullSecrets.namespaces | default "" -}}
redhatrises marked this conversation as resolved.
Show resolved Hide resolved
{{- if .Values.container.image.pullSecrets.allNamespaces }}
{{- $myns = list -}}
{{- range $index, $ns := (lookup "v1" "Namespace" "" "").items -}}
Expand Down
72 changes: 0 additions & 72 deletions helm-charts/falcon-sensor/templates/container_webhook_upgrade.yaml

This file was deleted.

13 changes: 0 additions & 13 deletions helm-charts/falcon-sensor/templates/daemonset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -96,18 +96,11 @@ spec:
imagePullPolicy: "{{ .Values.node.image.pullPolicy }}"
command:
- /bin/bash
{{- if .Values.node.gke.autopilot }}
args:
- '-c'
- >-
echo "Running /opt/CrowdStrike/falcon-daemonset-init -i";
/opt/CrowdStrike/falcon-daemonset-init -i
{{- else }}
args: ['-c', 'if [ -x "/opt/CrowdStrike/falcon-daemonset-init" ]; then echo "Running falcon-daemonset-init -i" ; /opt/CrowdStrike/falcon-daemonset-init -i ; else if [ -d "/host_opt/CrowdStrike/falconstore" ] ; then echo "Re-creating /opt/CrowdStrike/falconstore as it is a directory instead of a file"; rm -rf /host_opt/CrowdStrike/falconstore; fi; mkdir -p /host_opt/CrowdStrike && touch /host_opt/CrowdStrike/falconstore; fi']
volumeMounts:
- name: falconstore-dir
mountPath: /host_opt
{{- end }}
{{- if or .Values.node.gke.autopilot .Values.node.daemonset.resources }}
resources:
requests:
Expand Down Expand Up @@ -178,12 +171,6 @@ spec:
- name: falconstore
mountPath: /opt/CrowdStrike/falconstore
volumes:
{{- if not .Values.node.gke.autopilot }}
- name: falconstore-dir
hostPath:
path: /opt
type: DirectoryOrCreate
{{- end }}
- name: falconstore
hostPath:
path: /opt/CrowdStrike/falconstore
Expand Down
13 changes: 0 additions & 13 deletions helm-charts/falcon-sensor/templates/node_cleanup.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -88,18 +88,11 @@ spec:
imagePullPolicy: "{{ .Values.node.image.pullPolicy }}"
command:
- /bin/bash
{{- if .Values.node.gke.autopilot }}
args:
- '-c'
- >-
echo "Running /opt/CrowdStrike/falcon-daemonset-init -u";
/opt/CrowdStrike/falcon-daemonset-init -u
{{- else }}
args: ['-c', 'if [ -x "/opt/CrowdStrike/falcon-daemonset-init" ]; then echo "Running /opt/CrowdStrike/falcon-daemonset-init -u"; /opt/CrowdStrike/falcon-daemonset-init -u ; else rm -rf "/host_opt/CrowdStrike"; fi']
volumeMounts:
- name: opt-crowdstrike
mountPath: /host_opt
{{- end }}
{{- if or .Values.node.gke.autopilot .Values.node.daemonset.resources }}
resources:
requests:
Expand Down Expand Up @@ -150,12 +143,6 @@ spec:
privileged: false
readOnlyRootFilesystem: true
allowPrivilegeEscalation: true
{{- if not .Values.node.gke.autopilot }}
volumes:
- name: opt-crowdstrike
hostPath:
path: /opt
{{- end }}
serviceAccountName: {{ .Values.serviceAccount.name }}-node-cleanup
terminationGracePeriodSeconds: {{ .Values.node.terminationGracePeriod }}
hostPID: true
Expand Down