feat(iar): adding registryConfigJSON and fixing the pullSecret usage #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
falcon-pioupiou
commented
Feb 8, 2024
falcon-pioupiou
commented
- pullSecret property is not working : it was creating a secret based on the value and not doing a reference to it
- adding the support of the registryConfigJSON to have a consistent way to deploy like other agents (simpler to use than the dockerAPIToken based on the tooling we have today)
falcon-pioupiou
force-pushed
the
iar-add-registryConfigJSON
branch
3 times, most recently
from
ee4b1ee to
04dd3bd
Compare
- pullSecret property is not working : it was creating a secret based on the value and not doing a reference to it - adding the support of the registryConfigJSON to have a consistent way to deploy like other agents (simpler to use than the dockerAPIToken based on the tooling we have today) - bump Chart to v1.1.2
falcon-pioupiou
force-pushed
the
iar-add-registryConfigJSON
branch
from
04dd3bd to
4d56371
Compare
cs-pvyas
approved these changes
Feb 8, 2024
cs-pvyas
reviewed
Feb 8, 2024
cs-pvyas
reviewed
Feb 8, 2024
redhatrises
force-pushed
the
iar-add-registryConfigJSON
branch
from
a3f9789 to
f975ce0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.