Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add read permissions for resources that are monitored by KAC #245

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

pflanagan-cs
Copy link
Contributor

For dry-run mode, falcon-kac needs read permissions on the resources it validates as admission controller webhook

@redhatrises
Copy link
Contributor

To be clear, we aren't talking about helm's dry-run correct?

@pflanagan-cs pflanagan-cs force-pushed the kac-add-read-permissions branch from 4a9b060 to 1eb5784 Compare December 20, 2023 14:44
@pflanagan-cs
Copy link
Contributor Author

To be clear, we aren't talking about helm's dry-run correct?
Correct. This is to allow a dryrun of KAC admission controller to see what errors it would report if it was reviewing existing resources

@redhatrises redhatrises merged commit 3f14596 into CrowdStrike:main Dec 20, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants