feat(falcon-sensor): allow helm hook manifests to be disabled

Signed-off-by: congiv <[email protected]>
CrowdStrike · Apr 13, 2024 · 1d0b85b · 1d0b85b
1 parent 2aa1642
commit 1d0b85b
Show file tree

Hide file tree

Showing 6 changed files with 25 additions and 4 deletions.
diff --git a/helm-charts/falcon-sensor/Chart.yaml b/helm-charts/falcon-sensor/Chart.yaml
@@ -15,7 +15,7 @@ type: application
 # This is the chart version. This version number should be incremented each time you make changes
 # to the chart and its templates, including the app version.
 # Versions are expected to follow Semantic Versioning (https://semver.org/)
-version: 1.26.1
+version: 1.27.0
 
 # This is the version number of the application being deployed. This version number should be
 # incremented each time you make changes to the application. Versions are not expected to

diff --git a/helm-charts/falcon-sensor/templates/node_cleanup.yaml b/helm-charts/falcon-sensor/templates/node_cleanup.yaml
@@ -1,4 +1,4 @@
-{{- if .Values.node.enabled }}
+{{- if and .Values.node.enabled .Values.node.hooks.postDelete.enabled }}
 apiVersion: apps/v1
 kind: DaemonSet
 metadata:

diff --git a/helm-charts/falcon-sensor/templates/node_secret_cleanup.yaml b/helm-charts/falcon-sensor/templates/node_secret_cleanup.yaml
@@ -1,4 +1,4 @@
-{{- if .Values.node.enabled }}
+{{- if and .Values.node.enabled .Values.node.hooks.postDelete.enabled }}
 {{- if .Values.node.image.registryConfigJSON }}
 {{- $registry := .Values.node.image.registryConfigJSON }}
 apiVersion: v1

diff --git a/helm-charts/falcon-sensor/templates/serviceaccount_cleanup.yaml b/helm-charts/falcon-sensor/templates/serviceaccount_cleanup.yaml
@@ -1,3 +1,4 @@
+{{- if and .Values.node.enabled .Values.node.hooks.postDelete.enabled }}
 apiVersion: v1
 kind: ServiceAccount
 metadata:
@@ -10,4 +11,5 @@ metadata:
     helm.sh/chart: {{ include "falcon-sensor.chart" . }}
   annotations:
     "helm.sh/hook": post-delete
-    "helm.sh/hook-weight": "0"
+    "helm.sh/hook-weight": "0"
+{{- end }}
diff --git a/helm-charts/falcon-sensor/values.schema.json b/helm-charts/falcon-sensor/values.schema.json
@@ -255,6 +255,20 @@
                     "type": "integer",
                     "default": "30",
                     "pattern": "^[0-9]+$"
+                },
+                "hooks": {
+                    "type": "object",
+                    "properties": {
+                        "postDelete": {
+                            "type": "object",
+                            "properties": {
+                                "enabled": {
+                                    "type": "boolean",
+                                    "default": "true"
+                                }
+                            }
+                        }
+                    }
                 }
             }
         },

diff --git a/helm-charts/falcon-sensor/values.yaml b/helm-charts/falcon-sensor/values.yaml
@@ -99,6 +99,11 @@ node:
   # How long to wait for Falcon pods to stop gracefully
   terminationGracePeriod: 30
 
+  hooks:
+    # Settings for the node post-delete helm hook
+    postDelete:
+      enabled: true
+
 container:
   # When enabled, Helm chart deploys the Falcon Container Sensor to Pods through Webhooks
   enabled: false