Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ember-async-data #147

Conversation

NullVoxPopuli
Copy link
Contributor

@NullVoxPopuli NullVoxPopuli commented Jun 1, 2023

version 0.7.0 isn't compatible with native types from ember-source.

Includes change from #148

@changeset-bot
Copy link

changeset-bot bot commented Jun 1, 2023

🦋 Changeset detected

Latest commit: 67bc6c3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
ember-headless-form Patch
docs-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@NullVoxPopuli NullVoxPopuli changed the title Upgrade ember-asyncn-data Upgrade ember-async-data Jun 1, 2023
Copy link
Contributor

@simonihmig simonihmig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and CI seems also happy. But before merging I'd like to wait at least a day or two on feedback for this question

@simonihmig simonihmig merged commit 6984523 into CrowdStrike:main Jun 12, 2023
@github-actions github-actions bot mentioned this pull request Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants