Yield submit and reset actions
#136
Conversation
🦋 Changeset detectedLatest commit: da9f16c The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| @@ -153,4 +154,159 @@ module('Integration Component HeadlessForm > Reset', function (hooks) { | |||
| .doesNotExist('form.submissionState is resetted'); | |||
| }); | |||
| }); | |||
|
|
|||
| module('reset action', function () { | |||
There was a problem hiding this comment.
This is duplicating the same tests as for the reset button. Not sure if/how we should try to DRY this, but I thought for tests some duplication is ok, instead of trying to be too clever in tests?
There was a problem hiding this comment.
for tests some duplication is ok, instead of trying to be too clever in tests
100% agree!
Preview URLsEnv: preview |
| @@ -153,4 +154,159 @@ module('Integration Component HeadlessForm > Reset', function (hooks) { | |||
| .doesNotExist('form.submissionState is resetted'); | |||
| }); | |||
| }); | |||
|
|
|||
| module('reset action', function () { | |||
There was a problem hiding this comment.
for tests some duplication is ok, instead of trying to be too clever in tests
100% agree!
<HeadlessForm>yieldssubmit(I thought we already had this, but apparently we did not) andresetactions (part of #117), that can be used in place of the native buttons.