fix: i18n in app router #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
enpitsuLin
commented
May 6, 2023
| <strong className="font-medium">xLog</strong> is the best{" "} | ||
| <UniLink | ||
| <a |
There was a problem hiding this comment.
IMHO, In RSC, we shouldn't use components that may be both pure function component and stateful component (next/link) like <UniLink/>, so I just replace to anchor tag here
|
|
||
| import { Trans, useTranslation } from "next-i18next" | ||
| import { useRouter } from "next/navigation" | ||
| import { Element, Link } from "react-scroll" |
There was a problem hiding this comment.
we cant use class component in RSC so replace it to native anchor
| @@ -12,6 +12,7 @@ export default async function HomeLayout({ | |||
| }) { | |||
| return ( | |||
| <> | |||
| {/* @ts-expect-error RSC */} | |||
| @@ -0,0 +1,142 @@ | |||
| "use client" | |||
There was a problem hiding this comment.
some component in @crossbell/ui cause RSC error
enpitsuLin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #492
fix i18n problem
For client component => use props to display translated text , see
src/app/(home)/components/EntranceButton.tsx(maybe there are better way)For server components just add a hook to get
headers['accept-language']as langId and use it in async component withuseTranslationinsrc/lib/i18nor<Trans/>export fromreact-i18next/TransWithoutContext