Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/fix triggers on load event when replace image #317

Merged
merged 15 commits into from
Mar 30, 2024
Merged

Feature/fix triggers on load event when replace image #317

merged 15 commits into from
Mar 30, 2024

Conversation

MaxymGorn
Copy link
Member

@MaxymGorn MaxymGorn commented Mar 30, 2024 •
edited
Loading

Target

Fix triggers on load event when replace image

Open Questions

Checklist

  • Documentation updated
  • Tests cover new or modified code
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New dependencies added
  • Includes breaking changes
  • Version bumped

Visuals

@MaxymGorn MaxymGorn requested a review from ColdForeign March 30, 2024 17:42
@codecov Codecov
Copy link

codecov bot commented Mar 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b3bf289) to head (1fb7264).

Additional details and impacted files 
@@            Coverage Diff            @@
##               dev      #317   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines          667       670    +3     
  Branches        63        64    +1     
=========================================
+ Hits           667       670    +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MaxymGorn MaxymGorn enabled auto-merge (squash) March 30, 2024 17:58
@MaxymGorn MaxymGorn added documentation Improvements or additions to documentation enhancement New feature or request dependencies Pull requests that update a dependency file labels Mar 30, 2024
@MaxymGorn MaxymGorn merged commit faea1ec into dev Mar 30, 2024
10 checks passed
@MaxymGorn MaxymGorn deleted the feature/fix_triggers_on_load_event_when_replace_image branch March 30, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ColdForeign ColdForeign ColdForeign approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaxymGorn @ColdForeign