Add arg check

CreamFi · Aug 19, 2022 · f90921f · f90921f
1 parent d5223cd
commit f90921f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/contracts/PriceOracle/PriceOracleProxyIB.sol b/contracts/PriceOracle/PriceOracleProxyIB.sol
@@ -182,6 +182,7 @@ contract PriceOracleProxyIB is PriceOracle, Exponential, Denominations {
      */
     function _setAdmin(address _admin) external {
         require(msg.sender == admin, "only the admin may set new admin");
+        require(_admin != address(0), "invalid admin");
         admin = _admin;
         emit SetAdmin(admin);
     }

diff --git a/tests/PriceOracleProxyIBTest.js b/tests/PriceOracleProxyIBTest.js
@@ -122,6 +122,10 @@ describe('PriceOracleProxyIB', () => {
     it("fails to set admin for non-admin", async () => {
       await expect(send(oracle, "_setAdmin", [accounts[0]], {from: accounts[0]})).rejects.toRevert("revert only the admin may set new admin");
     });
+
+    it("fails to set admin invalid admin", async () => {
+      await expect(send(oracle, "_setAdmin", [address(0)])).rejects.toRevert("revert invalid admin");
+    });
   });
 
   describe("_setGuardian", () => {